Re: SERVICE_WANT_PREFIX

[Olivier Galibert <Olivier.Galibert@xxxxxxxxxxxxxxxx>]

On Wed, Aug 20, 1997 at 11:15:24AM +0200, Bjorn Reese wrote:
> I cannot receive n!u@h style even if I request SERVICE_WANT_PREFIX.
> 
> [10.58.37] XDEBUG: 4 <-- SERVICE convert irc.dknet.dk * 0 0 :Conversion Service
> [10.58.42] XDEBUG: 4 <-- SERVSET 65536 0
> [10.58.54] XDEBUG: 4 --> :stderr SQUERY convert@xxxxxxxxxxxx :help

Count that as a bug. Patch below.

> In addition, I'd like to suggest that since _PREFIX (and _TOKEN and
> _EXTNICK) are independent on the types in the S-line the service shouldn't
> be rejected if they are added to SERVICE.

It is already done that way.


> Btw, what does _EXTNICK do? "user extended NICK syntax" doesn't really
> ring a bell.

Without EXTNICK :
NICK Sarayan :1
:Sarayan USER galibert iria.mines.u-nancy.fr iria.mines.u-nancy.fr :If you ask me questions, cope with my answers
:Sarayan MODE Sarayan +i


With EXTNICK :
NICK Sarayan 1 galibert iria.mines.u-nancy.fr iria.mines.u-nancy.fr +i :If you ask me questions, cope with my answers

  OG.

*** s_service.c.1	Wed Aug 20 12:15:07 1997
--- s_service.c	Wed Aug 20 12:20:26 1997
***************
*** 697,702 ****
--- 697,708 ----
  	    }
  
  	if ((acptr = best_service(parv[1], NULL)))
+ 	    if (MyConnect(acptr) &&
+ 		(acptr->service->wants & SERVICE_WANT_PREFIX))
+ 		sendto_one(acptr, ":%s!%s@%s SQUERY %s :%s",
+ 			   parv[0], sptr->user->username, sptr->user->host,
+ 			   acptr->name, parv[2]);
+ 	    else
  		sendto_one(acptr, ":%s SQUERY %s :%s",
  			   parv[0], acptr->name, parv[2]);
  	else